shibd commented on code in PR #22762:
URL: https://github.com/apache/pulsar/pull/22762#discussion_r1615378179


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java:
##########
@@ -1097,10 +1099,23 @@ private class PeekMessages extends CliCommand {
         @Option(names = { "-n", "--count" }, description = "Number of messages 
(default 1)", required = false)
         private int numMessages = 1;
 
+        @Option(names = { "-ssm", "--show-server-marker" },
+                description = "Enables the display of internal server write 
markers.", required = false)
+        private boolean showServerMarker = false;
+
+        @Option(names = { "-sta", "--show-txn-aborted" },
+                description = "Enables the display of messages from aborted 
transactions.", required = false)
+        private boolean showTxnAborted = false;
+
+        @Option(names = { "-stu", "--show-txn-uncommitted" },
+                description = "Enables the display of messages from 
uncommitted transactions.", required = false)
+        private boolean showTxnUncommitted = false;

Review Comment:
   Although the name "--transaction-isolation-level" is quite standard, it 
seems to be inconsistent with the other two parameters.
   
   Are there more considerations? For example, in the future, transactions 
might involve more isolation features.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to