MMirelli commented on code in PR #498:
URL: https://github.com/apache/pulsar-helm-chart/pull/498#discussion_r1626121680


##########
charts/pulsar/templates/broker-service.yaml:
##########
@@ -43,7 +44,17 @@ spec:
   - name: "{{ .Values.tlsPrefix }}pulsarssl"
     port: {{ .Values.broker.ports.pulsarssl }}
   {{- end }}
-  clusterIP: None
+  {{- if and .Values.broker.service .Values.broker.service.clusterIP }}
+  {{- if eq .Values.broker.service.clusterIP "auto" }}

Review Comment:
   Cannot find a good motivation, atm. Makes sense to me. 
   
   Addressed by 4d8e283



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to