dao-jun commented on code in PR #22707:
URL: https://github.com/apache/pulsar/pull/22707#discussion_r1626823163
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java:
##########
@@ -307,6 +307,7 @@ public CompletableFuture<Void> commitTxn(TxnID txnID, long
lowWaterMark) {
txnBuffer.commitAt(committedAtLedgerId, committedAtEntryId);
addTxnToTxnIdex(txnID, committedAtLedgerId);
}
+ updateLastDispatchablePosition(null);
Review Comment:
> Another point is that the transaction in InMemTransactionBuffer does not
effect the lastDispatchablePosition.
It is because of I don't want to introduce `Separated` solution to
`InMemoryTxnBuffer`, just make it consistent with `TopicTxnBuffer`, let it
easier to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
