lhotari commented on code in PR #22861:
URL: https://github.com/apache/pulsar/pull/22861#discussion_r1635850544


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/DefaultKeySharedMessageListenerExecutor.java:
##########


Review Comment:
   I don't thing that we want to expose this at all. Users would start 
depending on these classes if they are public. 
   It would implicitly become part of the public API of the client in that 
case. Good APIs never break and we couldn't change that. If someone wants to 
use the MessageListenerExecutor, they should provide their own implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to