lhotari commented on code in PR #22861: URL: https://github.com/apache/pulsar/pull/22861#discussion_r1635859771
########## pulsar-client/src/main/java/org/apache/pulsar/client/impl/DefaultKeySharedMessageListenerExecutor.java: ########## Review Comment: This class can be removed completely. Please see https://github.com/apache/pulsar/pull/22861/files#r1635859386 ########## pulsar-client/src/main/java/org/apache/pulsar/client/impl/DefaultMessageListenerExecutor.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.impl; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ExecutorService; +import org.apache.commons.lang3.StringUtils; +import org.apache.pulsar.client.api.Message; +import org.apache.pulsar.client.util.ExecutorProvider; + +/** + * Default implementation of {@link AbstractMessageListenerExecutor}. + * This implementation will select thread by topic name to execute the runnable, + * So that message with same topic name will be executed by same thread. + * + * <p> + * The caller should shut down the executor when it is no longer needed. + * </p> + */ +public class DefaultMessageListenerExecutor extends AbstractMessageListenerExecutor { Review Comment: This class can be removed completely. Please see https://github.com/apache/pulsar/pull/22861/files#r1635859386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
