dragosvictor opened a new pull request, #23035: URL: https://github.com/apache/pulsar/pull/23035
[PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md) ### Motivation Adds messaging rate limit metrics, currently exposed in classes `InflightReadsLimiter` and `ServerCnxThrottleTracker`, to the OpenTelemetry pipeline. ### Modifications - Added metrics, as described by https://github.com/apache/pulsar-site/pull/943, to the OpenTelemetry pipeline. - The metrics differ slightly from the existing ones: - Connection throttling metrics are cumulative totals, instead of the instantaneous value in the existing Prometheus metric `pulsar_broker_throttled_connections`. This gives better visibility into the frequency of rate limiting operations. - Connection throttling metrics are exposed for pause/resume operations too. - Managed ledger inflight reads metrics expose both the hard-wired limit and current usage, for increased visibility. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - Updated tests `InflightReadsLimiterTest#testDisabled` and `InflightReadsLimiterTest#testBasicAcquireRelease` to cover the changes to the `InflightReadsLimiter` metrics - Updated tests in `MessagePublishBufferThrottleTest` to verify connection pause/unpause metrics - Added test `MessagePublishBufferThrottleTest#testConnectionThrottled` to verify connection throttle/unthrottle metrics ### Does this pull request potentially affect one of the following parts: - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [x] The metrics: _As described in https://github.com/apache/pulsar-site/pull/943_ - [ ] Anything that affects deployment ### Documentation - [ ] `doc` <!-- Your PR contains doc changes. --> - [x] `doc-required` https://github.com/apache/pulsar-site/pull/943 - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/dragosvictor/pulsar/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
