Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687509325
##########
oauth2/client_credentials_provider_test.go:
##########
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret := "CLIENT_SECRET"
ClientEmail := "CLIENT_EMAIL"
IssuerURL := "ISSUER_URL"
+ Scope := "SCOPE"
keyFile := &KeyFile{
Type: oauthType,
ClientID: clientID,
ClientSecret: ClientSecret,
ClientEmail: ClientEmail,
IssuerURL: IssuerURL,
+ Scope: Scope,
Review Comment:
I've reworked the code a bit so it now in the actual Token request, that way
any usage of it has the logic.
My earlier implementation would have caused only the ones create earlier it
would only happen for those created by the method
NewDefaultClientCredentialsFlow and not newClientCredentialsFlow which is used
in the provider test file.
A change to the client_credentials_flow_test.go was added that should
verify, I however cannot run the test locally so currently only when it runs in
the CI pipelines I can verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
