dragosvictor commented on code in PR #23064:
URL: https://github.com/apache/pulsar/pull/23064#discussion_r1688435826
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java:
##########
@@ -993,5 +997,26 @@ public void disableBroker() throws Exception {
serviceUnitStateChannel.cleanOwnerships();
leaderElectionService.close();
brokerRegistry.unregister();
+ // Close the internal topics (if owned any) after giving up the
possible leader role,
+ // so that the subsequent lookups could hit the next leader.
+ closeInternalTopics();
+ }
+
+ private void closeInternalTopics() {
+ List<CompletableFuture<Void>> futures = new ArrayList<>();
+ for (String name : INTERNAL_TOPICS) {
+ futures.add(pulsar.getBrokerService().getTopicIfExists(name)
+ .thenAccept(topicOptional -> topicOptional.ifPresent(topic
-> topic.close(true)))
+ .exceptionally(__ -> {
+ log.warn("Failed to close internal topic:{}", name);
+ return null;
+ }));
+ }
+ try {
+ FutureUtil.waitForAll(futures)
+
.get(pulsar.getConfiguration().getMetadataStoreOperationTimeoutSeconds(),
TimeUnit.SECONDS);
Review Comment:
It's not clear to me that the metadata store timeout is the most relevant
choice here. What about `namespaceBundleUnloadingTimeoutMs` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
