dao-jun commented on code in PR #22735:
URL: https://github.com/apache/pulsar/pull/22735#discussion_r1689010471
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##########
@@ -133,10 +135,17 @@ public
BucketDelayedDeliveryTracker(PersistentDispatcherMultipleConsumers dispat
new MutableBucket(dispatcher.getName(),
dispatcher.getCursor(), FutureUtil.Sequencer.create(),
bucketSnapshotStorage);
this.stats = new BucketDelayedMessageIndexStats();
- this.numberDelayedMessages = recoverBucketSnapshot();
+
+ // Close the tracker if failed to recover.
+ try {
+ this.numberDelayedMessages = recoverBucketSnapshot();
+ } catch (RecoverDelayedDeliveryTrackerException e) {
+ close();
Review Comment:
No, only close the tracker when it recover failed, if move `close()` to the
finally scope, the tracker will be closed whether recovered success or failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
