coderzc commented on code in PR #23080:
URL: https://github.com/apache/pulsar/pull/23080#discussion_r1708777549
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -1113,7 +1114,7 @@ private ConsumerImpl<T>
createInternalConsumer(ConsumerConfigurationData<T> conf
return ConsumerImpl.newConsumerImpl(client, partitionName,
configurationData, client.externalExecutorProvider(),
partitionIndex, true, listener != null, subFuture,
- startMessageId, schema, interceptors,
+ startMessageId, schema, null,
Review Comment:
we can't remove interceptors from internal consumer directly this will make
other interceptor methods not work
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -379,6 +379,7 @@ protected Message<T> internalReceive(long timeout, TimeUnit
unit) throws PulsarC
long callTime = System.nanoTime();
try {
message = incomingMessages.poll(timeout, unit);
+ message = beforeConsume(message);
Review Comment:
Also need to call `beforeConsume` on internalReceiveAsync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
