zymap commented on code in PR #23204:
URL: https://github.com/apache/pulsar/pull/23204#discussion_r1723086308
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -683,12 +683,8 @@ public void updateSubscribeRateLimiter() {
}
private void asyncAddEntry(ByteBuf headersAndPayload, PublishContext
publishContext) {
- if (brokerService.isBrokerEntryMetadataEnabled()) {
- ledger.asyncAddEntry(headersAndPayload,
- (int) publishContext.getNumberOfMessages(), this,
publishContext);
- } else {
- ledger.asyncAddEntry(headersAndPayload, this, publishContext);
- }
+ ledger.asyncAddEntry(headersAndPayload,
Review Comment:
Since the transaction part needs to refactor the interface. So I didn't
include it in this cleanup. And the numberOfMessages is only used for the
interceptor. And the transaction didn't take care of the interceptor, so it
should be fine. We can use another PR to resolve the transaction issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
