liangyepianzhou commented on PR #2: URL: https://github.com/apache/pulsar-java-contrib/pull/2#issuecomment-2306505275
> Main remaining decision is to decide whether spotless and checkstyle should co-exist. I don't think that they should, but I could be wrong. Couldn't we just move to spotless, also in CI to enforce the style. > > It's worth putting some effort on this before accepting contributions since formatting will impact all files contributed to the repository. Any advice on this @nicoloboschi @tisonkun ? Indeed, normally it is enough to just use spotless when creating a new warehouse. But as a Pulsar incubation project. Because some of the functions may be contributed back to pulsar in the future. So I still added checkstyle and kept it consistent with pulsar. Of course, I could be wrong. 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
