StevenLuMT commented on code in PR #6: URL: https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1741334691
########## pulsar-rpc-contrib/src/main/java/org/apache/pulsar/rpc/contrib/client/ReplyListener.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.pulsar.rpc.contrib.client; + +import static org.apache.pulsar.rpc.contrib.common.Constants.ERROR_MESSAGE; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import lombok.RequiredArgsConstructor; +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.client.api.Consumer; +import org.apache.pulsar.client.api.Message; +import org.apache.pulsar.client.api.MessageListener; + +@Slf4j +@RequiredArgsConstructor +public class ReplyListener<V> implements MessageListener<V> { + private final ConcurrentHashMap<String, CompletableFuture<V>> pendingRequestsMap; + private final RequestCallBack<V> callBack; + + @Override + public void received(Consumer<V> consumer, Message<V> msg) { + String correlationId = msg.getKey(); + try { + if (!pendingRequestsMap.containsKey(correlationId)) { + log.warn("[{}] [{}] No pending request found for correlationId {}." + + " This may indicate the message has already been processed or timed out.", + consumer.getTopic(), consumer.getConsumerName(), correlationId); + } else { + CompletableFuture<V> future = pendingRequestsMap.get(correlationId); + String errorMessage = msg.getProperty(ERROR_MESSAGE); + if (errorMessage != null) { + if (callBack != null) { + callBack.onReplyError(correlationId, consumer.getSubscription(), errorMessage, future); + } else { + future.completeExceptionally(new Exception(errorMessage)); + } + } else { + if (callBack != null) { + callBack.onReplySuccess(correlationId, consumer.getSubscription(), msg.getValue(), future); + } else { + future.complete(msg.getValue()); + } + } + } + } finally { + consumer.acknowledgeAsync(msg).exceptionally(ex -> { + log.warn("[{}] [{}] Acknowledging message {} failed", msg.getTopicName(), correlationId, + msg.getMessageId(), ex); + return null; + }); + } + } +} Review Comment: Question5: I think the consumption scenario is a bit simple. Can we add some confirmation strategies, similar to Question4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
