heesung-sn commented on code in PR #23359:
URL: https://github.com/apache/pulsar/pull/23359#discussion_r1777641274
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -1234,6 +1234,9 @@ protected void handleBrokerRegistrationEvent(String
broker, NotificationType typ
handleBrokerCreationEvent(broker);
} else if (type == NotificationType.Deleted) {
log.info("BrokerRegistry detected the broker:{} registry has been
deleted.", broker);
+ if (brokerRegistry.getBrokerId().equals(broker)) {
+ brokerRegistry.registerAsync();
Review Comment:
Nit: It is counter-intuitive that this broker is still alive but receives
deletion events(maybe network issue?).
Can you add a comment for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
