lhotari commented on PR #23354: URL: https://github.com/apache/pulsar/pull/23354#issuecomment-2402033052
> In SchemaRegistryServiceImpl.java there are two `getSchema()` methods. > 1 - `getSchema(String schemaId)` > 2 - `getSchema(String schemaId, SchemaVersion version)` > In the first method after getting Schema it is checked that whether the Schema is deleted or not. In Second method it is not checked when Schema.version=Latest . > Adding the check can improve code. Instead of explaining how the code is implemented, please explain why it was a problem instead. You can show this is a test too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
