BewareMyPower opened a new pull request, #23433: URL: https://github.com/apache/pulsar/pull/23433
Fixes #23412 ### Motivation https://github.com/apache/pulsar/pull/23382 brings a regression to the broker stop phase, which could be blocked by waiting: - `healthCheckBrokerAsync` in `ServiceUnitStateChannelImpl#doCleanup`, which could be blocked for `metadataStoreOperationTimeoutSeconds` seconds (default: 30s) - `unloadNamespaceBundle` in `BrokerService#unloadNamespaceBundlesGracefully`, which could be blocked for `namespaceBundleUnloadingTimeoutMs` milliseconds (default: 1 min) for each problematic bundle The 2nd method could be blocked when `healthCheckBrokerAsync` failed with `NotFoundException` but the following steps were not skipped. ### Modifications - Check if the service unit state channel is disabled or closed via `channelDisabled` before `healthCheckBrokerAsync` - Optimize some logs to avoid printing the whole stacks - Improve the test to run it for 10 times in case of any flakiness introduced again. The `metadataStoreOperationTimeoutSeconds` and `namespaceBundleUnloadingTimeoutMs` configs are reduced to avoid waiting too long if the test will fail. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
