lhotari commented on code in PR #20032:
URL: https://github.com/apache/pulsar/pull/20032#discussion_r1798876637
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2103,8 +2103,10 @@ public void redeliverUnacknowledgedMessages() {
incomingQueueLock.unlock();
}
- // is channel is connected, we should send redeliver command to
broker
- if (cnx != null && isConnected(cnx)) {
+ // If a subscription command has been sent to the broker, it is
necessary to allow the redelivery
+ // request to be sent to the broker without checking the
connection state, as failing to do so would
+ // result in the client consumer epoch being bigger than the
broker consumer epoch.
Review Comment:
Why does the connection state check need to be skipped? It's mentioned in
the comment, but I don't understand the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
