lhotari commented on issue #23485: URL: https://github.com/apache/pulsar/issues/23485#issuecomment-2425701975
> I would like to share my findings about the test case. It tests the pausing of a multi-topic consumer by doing the following Very good analysis @pdolif ! One detail that caught my eye in the test is step 3: https://github.com/apache/pulsar/blob/7367f1c6553c83d7d335977b86ed38494c9485b7/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L3541-L3542 That violates principles of testing where tests should test the public API and externally observable behaviors. There are a lot of such tests in the Pulsar code base and we should also move towards a direction where this wouldn't carried forward. > It seems, that the multi-topic consumer is automatically resumed between steps 2 and 7 in `MultiTopicsConsumerImpl.resumeReceivingFromPausedConsumersIfNeeded()`. It might be different. the pausing logic seems to be different than what is tested. Calling `.pause()` will stop sending flow permits to broker and the pausing referenced in `MultiTopicsConsumerImpl.resumeReceivingFromPausedConsumersIfNeeded()` is a different matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
