rdhabalia commented on PR #23398: URL: https://github.com/apache/pulsar/pull/23398#issuecomment-2450918009
>> This behavior is unchanged overall. while the client is potentially preventing some of the messages sitting in the pending queue to be even sent out to the TCP pipe Umm.. I am still not clear. Can't we send THROTTLE_ERROR_CODE and handle it instead of introducing new command? >> The only reason this throttle ack receipt is introduced is to handle older clients, Correct. In that case, check client-version at broker side and don't trigger this workflow if client doesn't support the version. So, we don't need ACK response back from client. For information: check `ServerCnx.java -> int clientProtocolVersion = connect.getProtocolVersion();` >> This is done on the server side.. so if the frequency/unit of token bucket refill is different than 1 second, it will be accommodated accordingly. The client doesn't make any assumptions on this frequency/unit, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
