lhotari opened a new pull request, #23613:
URL: https://github.com/apache/pulsar/pull/23613
### Motivation
Currently it's tricky and confusing to enable the Netty leak detector for
Pulsar broker and Pulsar clients.
The current logic expects that `pulsar.allocator.leak_detection` is set. The
standard property for Netty is `io.netty.leakDetection.level` (legacy property
`io.netty.leakDetectionLevel`).
One additional challenge in setting the `pulsar.allocator.leak_detection`
property is that the value is case sensitive. It must be set to `Disabled`,
`Simple`, `Advanced` or `Paranoid` instead of `disabled`, `simple`, `advanced`
or `paranoid`.
### Modifications
- Allow setting the Netty leak detector for Pulsar brokers and Pulsar
clients by setting any one of the following system properties:
- `io.netty.leakDetectionLevel` (legacy Netty property)
- `io.netty.leakDetection.level` (standard Netty property)
- `pulsar.allocator.leak_detection` (Pulsar's property)
- When multiple properties are set, use the setting with the highest leak
detection level.
- Use case insensitive parsing of the setting since it's currently case
sensitive.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
