BewareMyPower commented on code in PR #1310:
URL: https://github.com/apache/pulsar-client-go/pull/1310#discussion_r1855701470
##########
pulsar/consumer_partition.go:
##########
@@ -949,6 +949,11 @@ func (pc *partitionConsumer) Close() {
// wait for request to finish
<-req.doneCh
+
+ // It will close `queueCh.in`. If `MessageReceived` was called after
that, it will panic because new messages
+ // will be sent to a closed channel. However, generally it's impossible
because the broker will not be able to
+ // dispatch messages to this consumer after receiving the close request.
+ pc.queueCh.stop()
Review Comment:
Yes, it should call `close(closeCh)` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
