nodece commented on code in PR #1323:
URL: https://github.com/apache/pulsar-client-go/pull/1323#discussion_r1900526363
##########
pulsar/internal/rpc_client.go:
##########
@@ -64,6 +64,9 @@ type RPCClient interface {
RequestToHost(serviceNameResolver *ServiceNameResolver, requestID
uint64,
cmdType pb.BaseCommand_Type, message proto.Message)
(*RPCResult, error)
+ RequestWithCnxKeySuffix(logicalAddr *url.URL, physicalAddr *url.URL,
cnxKeySuffix int32, requestID uint64,
Review Comment:
@shibd You can change the `Request` method to avoid introducing an
unnecessary method because the `PRCClient` is an internal interface. I checked
the usage of the `Request` method and found one call now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
