lhotari commented on code in PR #23804:
URL: https://github.com/apache/pulsar/pull/23804#discussion_r1901518565
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java:
##########
@@ -243,6 +243,19 @@ public interface ConsumerBuilder<T> extends Cloneable {
*/
ConsumerBuilder<T> negativeAckRedeliveryDelay(long redeliveryDelay,
TimeUnit timeUnit);
+ /**
+ * Sets the redelivery time precision bit count. The lower bits of the
redelivery time will be
+ * trimmed to reduce the memory occupation. The default value is 8, which
means the redelivery time
+ * will be bucketed by 256ms, the redelivery time could be earlier(no
later) than the expected time,
+ * but no more than 256ms. If set to k, the redelivery time will be
bucketed by 2^k ms.
+ * If the value is 0, the redelivery time will be accurate to ms.
+ *
+ * @param negativeAckPrecisionBitCnt
+ * The redelivery time precision bit count.
+ * @return the consumer builder instance
+ */
+ ConsumerBuilder<T> negativeAckPrecisionBitCnt(int
negativeAckPrecisionBitCnt);
Review Comment:
abbrevations such as `Cnt` don't make much sense in public APIs. I'd
recommend using `Count` instead of `Cnt`.
Just wondering if `negativeAckRedeliveryDelayPrecision` would be a
sufficient name for the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
