lhotari commented on code in PR #23828: URL: https://github.com/apache/pulsar/pull/23828#discussion_r1908140640
########## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java: ########## Review Comment: I don't recommend starting Pulsar contributions in making such refactoring in tests. This would cause a lot of churn in the code base without much added value. We should first have a broader discussion around test improvements on the dev mailing list and then proceed into action. @heesung-sn has started such a discussion with PIP-390 https://github.com/apache/pulsar/pull/23565, thread is https://lists.apache.org/thread/fn3rk1x7v9291qh3g6vf4jxhvq6zc4mm . You are welcome to participate in the discussion and making the decisions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
