lhotari commented on PR #23815: URL: https://github.com/apache/pulsar/pull/23815#issuecomment-2581202385
> > > @lhotari This is a good idea. But ultimately, which configuration do we use? > > > > > > @nodece What do you mean exactly? Providing an example would be helpful. > > @lhotari > > * case1: The persisted state is true, and the consumer config is false, which is the ultimate value? > * case2: The persisted state is false, and the consumer config is true, which is the ultimate value? @nodece Wouldn't the goal be to use the persisted state? There's currently no javadoc for `replicateSubscriptionState` in ConsumerBuilder: https://github.com/apache/pulsar/blob/04e89fe2d841246e655bf875ba52cda2c2de0e3d/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java#L433-L437 . In the javadoc. In the javadoc, this could be stated explicitly that it's not possible to change the replicateSubscriptionState by a client for a subscription after it has been created. Perhaps there should be a separate admin operation to change this later? In any case, I think that documenting this change in a PIP would also be useful for the future. The [original PIP-31 doesn't clearly define how `replicateSubscriptionState` should behave](https://github.com/apache/pulsar/wiki/PIP-33%3A-Replicated-subscriptions#client-api). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
