lhotari opened a new pull request, #23876:
URL: https://github.com/apache/pulsar/pull/23876

   ### Motivation
   
   There's a test method `BrokerTestUtil.receiveMessages` that is used in some 
Key_Shared tests to asynchronously read messages from multiple consumers until 
no more new messages are arrived after a quiet time.
   The current implementation is wrong. Currently each consumer is handled 
separately and if an individual consumer times out, it would stop waiting for 
new messages even if a recent message arrived on another consumer. 
   This makes some Key_Shared blocking tests to fail with short time outs. This 
makes some tests flaky or fail when they shouldn't.
   Instead, the quiet time condition should be across all active consumers. 
   
   ### Modifications
   
   Fix the quiet time implementation in `BrokerTestUtil.receiveMessages`.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to