lhotari commented on code in PR #23884:
URL: https://github.com/apache/pulsar/pull/23884#discussion_r1942947118
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -95,6 +96,9 @@ public abstract class AbstractTopic implements Topic,
TopicPolicyListener {
protected static final long POLICY_UPDATE_FAILURE_RETRY_TIME_SECONDS = 60;
protected final String topic;
+ @Getter
+ @Setter
+ protected volatile CompletableFuture<Optional<Topic>> createFuture;
Review Comment:
Would it be possible to improve the comment? I'd recommend using Generative
AI (GitHub Copilot, ChatGPT, Claude, DeepSeek...) to cleanup such comments and
also improve their readability. The current comment "createFuture associated
with the topic to ensure safe removal from the cache of brokerService" is not
very useful for others.
This is the comment that Claude generated when I asked to improve comments
added in https://github.com/apache/pulsar/pull/23884.patch (I downloaded this
file and uploaded to Claude UI) :
```
// Reference to the CompletableFuture returned when creating this topic in
BrokerService.
// Used to safely remove the topic from BrokerService's cache by ensuring we
remove the exact
// topic instance that was created.
```
This comment would be more useful to others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
