poorbarcode commented on PR #23931: URL: https://github.com/apache/pulsar/pull/23931#issuecomment-2637054697
@lhotari >> The feature managedLedgerMaxReadsInFlightSize assumes the entry size is 10kb when it read nothing. Otherwise, it uses the average entries size of the entries read out before. > After https://github.com/apache/pulsar/pull/23901 changes this case would be very rare since it would apply only for the first read in case no entries were produced to the topic. Agree, but for the following case, the current solution is better - There are `50k` entries in the ledger - `1` entry was read out, the average size estimated is less accurate than the current implementation. - The topic was sent for `30` days, and the customer changed the schema of the topic. - `total size/ total count` is less accurate than the current implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
