lhotari commented on PR #23955: URL: https://github.com/apache/pulsar/pull/23955#issuecomment-2648249301
> Though I think catching the `IllegalReferenceCountException` from `value.retain()` is not a good practice and error prone, let's just keep the fix simple. `value.retain()` is essential since RangeCache is not synchronized. Removing the logic will cause problems in concurrent removals since that could currently happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
