geniusjoe opened a new issue, #23968:
URL: https://github.com/apache/pulsar/issues/23968

   ### Search before asking
   
   - [x] I searched in the [issues](https://github.com/apache/pulsar/issues) 
and found nothing similar.
   
   
   ### Motivation
   
   Issue: https://github.com/apache/pulsar-site/pull/507
   
   We now support consuming delayed messages with shared and Key-shared type 
subscriptions, which has been corrected since [pulsar 3.x 
doc](https://pulsar.apache.org/docs/3.0.x/concepts-messaging/#delayed-message-delivery)
 in above pr. 
   
   But Java code 
[deliverAt](https://github.com/apache/pulsar/blob/1ab63455c1f36062cbc587244f8c0c5f71be16c5/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/TypedMessageBuilder.java#L192)
 and 
[deliverAfter](https://github.com/apache/pulsar/blob/1ab63455c1f36062cbc587244f8c0c5f71be16c5/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/TypedMessageBuilder.java#L205)
 comment says we can only support Shared type subscription, so that maybe we 
need to fix them.
   
   ### Solution
   
   Replace `{@link SubscriptionType#Shared}` comment with `{@link 
SubscriptionType#Shared} or {@link SubscriptionType#Key_Shared}` in deliverAt 
and deliverAfter api.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to