thetumbled opened a new pull request, #23986: URL: https://github.com/apache/pulsar/pull/23986
Main Issue: https://github.com/apache/pulsar/issues/23885 ### Motivation When batch message is negative ack, some undetermined behavior may occur. For example, - There are 10 messages batched into one message, all of them are unbatch into consumer's receiver queue. - consumer negative ack the first 5 messages. - before the consumer negative ack another 5 messages, the negatve ack tracker trigger the redelivery request. - broker dispatch this batched message to consumer. - consumer clear the remaining 5 messages in the queue, and refill 10 messages into the queue. - Message duplication issue occurs. IMO, suck kind of problem is reasonable as we only provide At-Least-Once semantices. ### Modifications This unit test don't handle the batch case at some time. Negative ack one message is enough for this test in batch case. ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
