AnuragReddy2000 commented on code in PR #60:
URL: https://github.com/apache/pulsar-adapters/pull/60#discussion_r1960952081
##########
pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java:
##########
@@ -159,6 +159,21 @@ public void ack(Object msgId) {
}
}
+ public void negativeAck(Object msgId) {
Review Comment:
I was just following the same approach used in the `ack` and `fail` methods
in the same class, where the method argument is called `msgId` and has the type
`Object`. But inside the method, there is a check on whether `msgId` is an
instance of the `Message` class and then is type cast into the `Message` type
and assigned to a variable called `msg`.
Do you still want me to rename the argument to some other name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
