lhotari commented on PR #23770: URL: https://github.com/apache/pulsar/pull/23770#issuecomment-2673798407
> @lhotari Do you have more suggestions? If not, I will send a vote to the mailing list. @nodece I think that at the topic and namespace level, it could be better to combine `overwriteConsumerReplicateSubscriptionState` (you mentioned it in https://github.com/apache/pulsar/pull/23770#issuecomment-2560597473) and `replicateSubscriptionState` into a single enum instead of 2 separate boolean values to be used in policies. Let's say `ReplicateSubscriptionStatePolicy` enum with values: * `OVERRIDE_ENABLE` - overrides any value set by the consumer (or lower level policy) and enables subscription replication * `OVERRIDE_DISABLE` - overrides any value set by the consumer (or lower level policy) and enables subscription replication * `ENABLE` - enables subscription replication if not explicitly disabled by the consumer (or lower level policy) * `DISABLE` - disables subscription replication if not explicitly enabled by the consumer (or lower level policy) I don't know if this is accurate, but putting more thought in how to address the topic and namespace level would be useful. I haven't seen the APIs being updated to have this information in the policies. I don't think that introducing a completely separate concept for topic and namespace level makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
