jklinaku commented on code in PR #257:
URL: https://github.com/apache/pulsar-dotpulsar/pull/257#discussion_r1975024143
##########
src/DotPulsar/Schema.cs:
##########
@@ -101,4 +101,9 @@ static Schema()
/// Avro schema for classes that use ISpecificRecord
/// </summary>
public static AvroISpecificRecordSchema<T> AvroISpecificRecord<T>() =>
new();
+
+ /// <summary>
+ /// Avro schema for generic avro record, always give
Avro.Generic.GenericRecord
+ /// </summary>
+ public static AvroGenericRecordSchema<T> avroGenericRecordSchema<T>(string
jsonAvroSchema) => new(jsonAvroSchema);
Review Comment:
Right, i think ive missed the second part, i think we should go with
AvroISpecificRecord and AvroGenericRecord. Since it is more in the style of the
other schemas. Ill fix that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
