lhotari commented on code in PR #24020:
URL: https://github.com/apache/pulsar/pull/24020#discussion_r1980950149
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2294,17 +2295,16 @@ private CompletableFuture<Producer<byte[]>>
initDeadLetterProducerIfNeeded() {
p = deadLetterProducer;
if (p == null || p.isCompletedExceptionally()) {
p = createProducerWithBackOff(() -> {
- CompletableFuture<Producer<byte[]>> newProducer =
- ((ProducerBuilderImpl<byte[]>)
client.newProducer(Schema.AUTO_PRODUCE_BYTES(schema)))
-
.initialSubscriptionName(this.deadLetterPolicy.getInitialSubscriptionName())
-
.topic(this.deadLetterPolicy.getDeadLetterTopic())
- .producerName(
-
String.format("%s-%s-%s-%s-DLQ", this.topicName, this.subscription,
- this.consumerName,
RandomStringUtils.randomAlphanumeric(5)))
- .blockIfQueueFull(false)
- .enableBatching(false)
- .enableChunking(true)
Review Comment:
There was a slight misunderstanding regarding the
`DEFAULT_PRODUCER_BUILDER_CUSTOMIZER`. Remove it completely, it's not needed
when you revert the change to remove these lines above.
If the user would like to change the above settings, they could do that in
the customizer. It also is important for the "customizer" abstraction that
unless you do any changes in the customizer, the defaults will be use. The
customizer customizes the producer builder after the runtime has configured the
defaults. Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
