lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981058623
########## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilderCustomizer.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.api; + +/** + * Functional interface for customizing a producer builder for a specific topic. + * + * <p>This interface allows for customizing the producer builder configuration for either the retry letter topic + * or the dead letter topic. The customization might include setting producer properties such as batching, timeouts, + * or any other producer-specific configuration. + * + * @see ProducerBuilderContext + */ +public interface ProducerBuilderCustomizer { Review Comment: The naming isn't yet fully accurate. It would be useful to have a prefix that clarifies that this applies to deadletter topic and retry letter topic producer builders. `DeadLetterProducerBuilderCustomizer` would be consistent with `DeadLetterPolicy` which covers also the retry letter topic. Similarly `ProducerBuilderContext` would be `DeadLetterProducerBuilderContext`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
