lhotari commented on code in PR #24059:
URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981576337
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -824,6 +826,13 @@ private MessageImpl<?> getMessageImpl(Message<?> message) {
return null;
}
+ private static void copyMessageEventTimeIfNeeded(Message<?> message,
+
TypedMessageBuilder<byte[]> typedMessageBuilderNew) {
+ if (message.getEventTime() > 0) {
Review Comment:
In theory, the value could be negative if this was used for very long
timestamps < before January 1st, 1970. I guess the value could be copied as-is
without checking. The method name could reflect this by removing `IfNeeded`
from the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
