Copilot commented on code in PR #24161:
URL: https://github.com/apache/pulsar/pull/24161#discussion_r2033516621
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/CanReconnectZKClientPulsarServiceBaseTest.java:
##########
@@ -143,6 +150,7 @@ protected void makeLocalMetadataStoreKeepReconnectNetty() {
protected void stopLocalMetadataStoreAlwaysReconnect() {
LocalMetadataStoreInReconnectFinishSignal.set(false);
+ Awaitility.await().until(() ->
SessionEvent.Reconnected.equals(sessionEvent));
Review Comment:
The Awaitility call waits indefinitely if sessionEvent is never set to
Reconnected. Consider specifying a timeout to ensure the test fails gracefully
if the event is not received.
```suggestion
Awaitility.await().atMost(30, TimeUnit.SECONDS).until(() ->
SessionEvent.Reconnected.equals(sessionEvent));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
