lhotari commented on PR #23988: URL: https://github.com/apache/pulsar/pull/23988#issuecomment-2790377110
Some Pulsar tests are using MockZooKeeper's `delay` method. After #23988, MockZooKeeper is correctly single threaded and a delay will block the execution of this code in ZKSessionWatcher: https://github.com/apache/pulsar/blob/6e8c3496647df275071190aec9d29ecbcee55e80/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKSessionWatcher.java#L108-L115 This will trigger a ConnectionLost session event. That's why a delay should be kept under 2000 ms. Currently MockZooKeeper's session timeout is hard coded to 30000ms and the check interval is 1/15 of this, therefore 2000ms. It would be a good improvement to use the configured `metadataStoreSessionTimeoutMillis` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
