lhotari commented on PR #24166: URL: https://github.com/apache/pulsar/pull/24166#issuecomment-2792218936
> LGTM. However, this PR changes the topic name format from v1 to v2, which I am concerned will cause a conflict when cherry-picking this PR to the maintenance branches. > > Would make sense that create a new PR to improve that? It was necessary to change to v2 for the single test case so that topic policies can be used. Topic policies fail with v1 topics. Because of consistency, I changed the complete test class to use v2 topic format. @nodece I can handle resolving merge conflicts while cherry-picking, so no need to worry about that. I have a pretty good workflow for merge conflict resolution so that's not a big problem in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
