lhotari commented on code in PR #605:
URL: https://github.com/apache/pulsar-helm-chart/pull/605#discussion_r2073495828
##########
charts/pulsar/templates/oxia-coordinator-podmonitor.yaml:
##########
@@ -19,5 +19,5 @@
# deploy oxia-coordinator PodMonitor only when
`$.Values.oxia.coordinator.podMonitor.enabled` is true
{{- if and $.Values.components.oxia
$.Values.oxia.coordinator.podMonitor.enabled }}
-{{- include "pulsar.podMonitor" (list . "oxia.coordinator"
"app.kubernetes.io/component: oxia-coordinator" "metrics") }}
Review Comment:
one more detail is that "metrics" should be passed as the 4th parameter.
That's the port name to be used.
https://github.com/apache/pulsar-helm-chart/blob/7833e51c282527e6b0c229f9bb5bae043e7a54f8/charts/pulsar/templates/_monitor.tpl#L25-L27
https://github.com/apache/pulsar-helm-chart/blob/7833e51c282527e6b0c229f9bb5bae043e7a54f8/charts/pulsar/values.yaml#L514
https://github.com/apache/pulsar-helm-chart/blob/7833e51c282527e6b0c229f9bb5bae043e7a54f8/charts/pulsar/templates/oxia-coordinator-deployment.yaml#L63-L67
##########
charts/pulsar/templates/oxia-server-podmonitor.yaml:
##########
@@ -19,5 +19,5 @@
# deploy oxia-server PodMonitor only when
`$.Values.oxia.server.podMonitor.enabled` is true
{{- if and $.Values.components.oxia $.Values.oxia.server.podMonitor.enabled }}
-{{- include "pulsar.podMonitor" (list . "oxia.server"
"app.kubernetes.io/component: oxia-server" "metrics") }}
Review Comment:
one more detail is that "metrics" should be passed as the 4th parameter.
That's the port name to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
