sijie commented on a change in pull request #4955: [WIP] [PIP-39] Introduce 
system topic and topic policies service
URL: https://github.com/apache/pulsar/pull/4955#discussion_r315512176
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -652,8 +652,9 @@ private void createPersistentTopic(final String topic, 
boolean createIfMissing,
                         @Override
                         public void openLedgerComplete(ManagedLedger ledger, 
Object ctx) {
                             try {
-                                PersistentTopic persistentTopic = new 
PersistentTopic(topic, ledger,
-                                        BrokerService.this);
+                                PersistentTopic persistentTopic = 
isSystemTopic(topic)
 
 Review comment:
   `PersistentTopic persistentTopic = new PersistentTopic(topic, ledger, 
BrokerService.this, isSystemTopic(topic));`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to