lhotari commented on code in PR #19783:
URL: https://github.com/apache/pulsar/pull/19783#discussion_r2099928881
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2002,11 +2009,16 @@ CompletableFuture<ReadHandle> getLedgerHandle(long
ledgerId) {
void invalidateReadHandle(long ledgerId) {
CompletableFuture<ReadHandle> rhf = ledgerCache.remove(ledgerId);
if (rhf != null) {
- rhf.thenAccept(ReadHandle::closeAsync)
- .exceptionally(ex -> {
- log.warn("[{}] Failed to close a Ledger ReadHandle:",
name, ex);
- return null;
- });
+ rhf.thenCompose(r -> {
+ if (r instanceof OffloadedLedgerHandle) {
+ log.info("[{}] Closing ledger {} from offload driver {}",
name, ledgerId,
+
config.getLedgerOffloader().getOffloadDriverName());
+ }
+ return r.closeAsync();
+ }).exceptionally(ex -> {
+ log.warn("[{}] Failed to close Ledger ReadHandle {}:", name,
ledgerId, ex);
Review Comment:
Done. I had to add the logging inside the `.thenCompose` block to have the
ReadHandle instance available for the log message. I kept the original log
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
