lhotari commented on code in PR #24338: URL: https://github.com/apache/pulsar/pull/24338#discussion_r2102280498
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ########## @@ -641,6 +641,7 @@ public void recoverIndividualDeletedMessages(PositionInfo positionInfo) { if (positionInfo.getIndividualDeletedMessagesCount() > 0) { recoverIndividualDeletedMessages(positionInfo.getIndividualDeletedMessagesList()); } else if (positionInfo.getIndividualDeletedMessageRangesCount() > 0) { + lock.writeLock().lock(); Review Comment: I guess this should be just before the `try {` block so that there isn't a risk of the lock remaining locked when an exception happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org