lhotari commented on code in PR #24366:
URL: https://github.com/apache/pulsar/pull/24366#discussion_r2126708193
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicListWatcher.java:
##########
@@ -89,7 +89,7 @@ public TopicListWatcher(PatternConsumerUpdateQueue
patternConsumerUpdateQueue,
}
@Override
- public void connectionFailed(PulsarClientException exception) {
+ public boolean connectionFailed(PulsarClientException exception) {
boolean nonRetriableError =
!PulsarClientException.isRetriableError(exception);
if (nonRetriableError) {
Review Comment:
just wondering why there isn't `return false` in the end of this code block
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java:
##########
@@ -122,7 +122,7 @@ public void start() {
}
@Override
- public void connectionFailed(PulsarClientException exception) {
+ public boolean connectionFailed(PulsarClientException exception) {
boolean nonRetriableError =
!PulsarClientException.isRetriableError(exception);
boolean timeout = System.currentTimeMillis() > lookupDeadline;
if (nonRetriableError || timeout) {
Review Comment:
just wondering why there isn't `return false` in the end of this code block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
