lhotari opened a new pull request, #24392:
URL: https://github.com/apache/pulsar/pull/24392

   ### Motivation
   
   `maxBatchDeletedIndexToPersist` has been hard coded to 10000 in Pulsar code 
base. It's better to make this configurable and also document the setting 
properly in `broker.conf`. 
   `managedLedgerPersistIndividualAckAsLongArray` setting was also missing from 
`broker.conf` and it's existing documentation in `ServiceConfiguration.java` 
didn't explain the impact to end users. 
   
   ### Modifications
   
   - make `maxBatchDeletedIndexToPersist` by adding 
`managedLedgerMaxBatchDeletedIndexToPersist` setting
   - add `managedLedgerPersistIndividualAckAsLongArray` to `broker.conf`
   - improve documentation for all of these settings
   
   ### Additional Context
   
   - Another PR #24391 adds `managedCursorInfoCompressionType` and 
`managedLedgerInfoCompressionType` settings to `broker.conf`. 
`managedCursorInfoCompressionType` is also related to persisting 
acknowledgement state.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to