codelipenghui commented on code in PR #24311:
URL: https://github.com/apache/pulsar/pull/24311#discussion_r2155866288
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/util/SchemaUtil.java:
##########
@@ -32,12 +32,16 @@
public class SchemaUtil {
+ public static boolean DEFAULT_JSR310_CONVERSION_ENABLED = false;
+
public static boolean getJsr310ConversionEnabledFromSchemaInfo(SchemaInfo
schemaInfo) {
- if (schemaInfo != null) {
- return Boolean.parseBoolean(schemaInfo.getProperties()
-
.getOrDefault(SchemaDefinitionBuilderImpl.JSR310_CONVERSION_ENABLED, "false"));
Review Comment:
Hi @adrianiacobghiula
Here uses `getOrDefault`, which should already provide the ability to
override. Do you have a test to reproduce this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
