poorbarcode opened a new pull request, #24443: URL: https://github.com/apache/pulsar/pull/24443
### Motivation https://github.com/apache/pulsar/pull/8659 introduced adding `batchSize` into `CommandAck` to check conflict commits if enabled TXN. Issue: The PR forgot to add `batchSize` into `CommandAck` when calling `consumer.acknowledgeAsync(List<MessageId>)`, which causes a negative unacknowledged messages of the consumer. You can reproduce the issue with the new test `testUnackMessageAfterAckAllMessages(true, true, true)`. ### Modifications - Add `batchSize` into `CommandAck` when calling `consumer.acknowledgeAsync(List<MessageId>)` - Disable the test `TransactionEndToEndWithoutBatchIndexAckTest.testAckWithTransactionReduceUnAckMessageCount`, because it is meaningless if the client-side enables batch ack and the broker-side disables batch ack(we need a PIP to deny this behavior in the future). ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
