3pacccccc commented on PR #24449: URL: https://github.com/apache/pulsar/pull/24449#issuecomment-3004474758
> > I'm wondering does `lastDispatchablePosition.compareTo(lastCompactedPosition) > 0` really means need to triggering compaction? For example, I publish a message with no key present after last compaction, there's actually no need to triggering compaction as well. > > if `topicCompactionRetainNullKey=false`, then a message with no key may be deleted during compaction, so trigger compaction task is meaningful OK, I get it, thank you, now LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
