codelipenghui commented on code in PR #24441:
URL: https://github.com/apache/pulsar/pull/24441#discussion_r2167843132
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpFindNewest.java:
##########
@@ -115,34 +120,131 @@ public void readEntryComplete(Entry entry, Object ctx) {
} else {
// start binary search
state = State.searching;
- searchPosition = ledger.getPositionAfterN(startPosition,
mid(), PositionBound.startExcluded);
+ this.mid = mid();
+ searchPosition = ledger.getPositionAfterN(startPosition,
this.mid, PositionBound.startExcluded);
Review Comment:
@coderzc could you please also help check line:104 which was added by
https://github.com/apache/pulsar/pull/22891/files#diff-7d6cd459f9134d4aeda2418630110e5abefdf6d367f6e83747c65f8637a6f851R99-R100?
It should be duplicated with line:102?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
